FindBoost.cmake (Was: kdesupport-for-4.2 cmake error)

[Andreas Pakulat]

On 17.01.09 20:09:44, Allen Winter wrote:
> On Saturday 17 January 2009 7:51:44 pm Pau Garcia i Quiles wrote:
> > Hello,
> > 
> > FindBoost.cmake in that version of kdesupport and in CMake 2.6.2 does
> > not support Boost 1.37.0. You need to replace this line:
> > 
> > SET( _boost_TEST_VERSIONS ${Boost_ADDITIONAL_VERSIONS} "1.36.1"
> > "1.36.0" "1.35.1" "1.35.0" "1.35" "1.34.1" "1.34.0" "1.34" "1.33.1"
> > "1.33.0" "1.33" )
> > 
> > with
> > 
> > SET( _boost_TEST_VERSIONS ${Boost_ADDITIONAL_VERSIONS} "1.37.0"
> > "1.36.1" "1.36.0" "1.35.1" "1.35.0" "1.35" "1.34.1" "1.34.0" "1.34"
> > "1.33.1" "1.33.0" "1.33" )
> > 
> This is quite silly.

You should tell that the boost people, who include these version numbers
into their libraries and include dirs. Making it pretty much impossible to
find boost.

> We really should have a FindBoost that is smarter and doesn't need to be
> updated each time a new Boost is released.

It doesn't, all you need to do is set Boost_ADDITIONAL_VERSIONS before
calling find_package. You can also view this as a good thing, because it
means the developers need to test-compile with a newer boost version. IIRC
kdevplatform doesn't build with newer boost, because boost broke some
backward compatibility.

> Wow, FindBoost.cmake is one intense piece of CMake code.

Right and btw, why do we have our own FindBoost.cmake, the one in cmake
2.6.2 is good enough (AFAIK) and hence we should be using that one. Also in
akonadi (unless they want to support cmake 2.4).

Andreas 

-- 
You will be surrounded by luxury.