QEdje scriptengine cannot be built + PATCH

[Joseph Wenninger]

My basic problem was that qzion.h and qedje.h and the libraries where not 
correctly found, if they where not in the same prefix. 

If there are upstream packages of qedje/qzion with the  patch applied we can 
remove the check for eet again anytime, but till then I think we should keep 
that additional check in

Regards
Joseph

On Saturday 03 January 2009 14:36:07 Sune Vuorela wrote:
> This is actually not a good fix, but a workaround of a bug in qedje.
>
> The real fix is to not look for Eet.h and not to link with libeet and apply
> this patch to qedje:
> http://svn.debian.org/wsvn/pkg-
> kde/krap/qedje/trunk/debian/patches/no_public_eet.h_needed.diff?op=file&rev
>=0&sc=0
>
> eet is not a part of the public api nor part of the abi in qedje.
>
> Hope this can be fixed the real way.
>
> /Sune
>
> On Thursday 01 January 2009 20:34:20 Joseph Wenninger wrote:
> > I've commited it now in r904277
> >
> > Regards
> > Joseph
> >
> > On Thursday 01 January 2009 19:46:22 Alexander Neundorf wrote:
> > > On Thursday 01 January 2009, Joseph Wenninger wrote:
> > > > Hi!
> > > >
> > > > I got the mail too late, so I had commited my previous patch already.
> > > > Attached is a new one, which doesn't use the PC_ variable directly in
> > > > the CMakeLists.txt file.
> > > >
> > > > Is this one better / okay?
> > >
> > > Much better :-)
> > > One nitpick: please prefix all variables you introduce in some module
> > > with the same prefix, especially if they go into the cache (which are
> > > all result variables of FIND_XXX()).
> > > So please make QEdje_INCLUDE_DIR a QEDJE_QEdje_INCLUDE_DIR and
> > > QZion_INCLUDE_DIR a QEDJE_QZion_INCLUDE_DIR, etc.
> > > This helps later on finding out where they come from and it also makes
> > > cmake-gui group them nicely into a treeview.
> > >
> > > And also please use MARK_AS_ADVANCED() for all result variables of the
> > > FIND_XXX() calls (except those which have some key importance, but I
> > > think there is no such variable here. For Qt4 this is e.g. the location
> > > of qmake).
> > >
> > > Please go ahead and commit with these changes.
> > >
> > > Alex



-- 
Who fights may lose, but who doesn't fight at all has already lost
KATE developer - Joseph Wenninger <jowenn at kde.org>