Created: kdepimlibs_include_dirs
Alexander Neundorf
neundorf at kde.org
Tue Feb 24 00:00:39 CET 2009
On Monday 23 February 2009, Christophe Giboudeaux wrote:
> On Monday 23 February 2009 19:55:48 Alexander Neundorf wrote:
> > On Monday 23 February 2009, Christophe Giboudeaux wrote:
> > > Hello,
> > >
> > > Yesterday we created the KDEPIMLIBS_INCLUDE_DIRS definition in
> > > kdepimlibs.
> > >
> > > This one resolves compilation errors if:
> > > - CamelCase headers are used and
> > > - the kdepimlibs installation prefix is not the same as the kdelibs
> > > one.
> >
> > That's this patch, right ?
> > http://websvn.kde.org/trunk/KDE/kdepimlibs/KdepimLibsConfig.cmake.in?r1=9
> >30 029&r2=930092
>
> Yes, note that originally, it was:
> set(KDEPIMLIBS_INCLUDE_DIR "@KDEPIMLIBS_INCLUDE_DIR@")
>
> It was illogical to use singular (_DIR vs. _DIRS) while we were including
> two directories.
Yes, I saw that. Using the plural form is the right thing to do here.
...
> > I didn't check the CamelCase headers yet. Where are they installed ?
> > E.g. if I install kdepimlibs to /opt/kdepimlibs, they will be installed
> > to /opt/kdepimlibs/include/KDE ?
> > Why not installing them e.g. to /opt/kdepimlibs/include/KdepimLibs ?
>
> For consistency mostly. For whoever installs kdelibs and kdepimlibs in the
> same prefix, all the CamelCase headers will be in ${KDE4_INCLUDE_DIR}/KDE
> and this issue won't even be noticed.
Yes, here I'm not sure it wouldn't be better to have a separate directory,
since kdepimlibs is also a separate package.
It's up to you, but I think I would prefer a separate subdirectory.
Alex
More information about the Kde-buildsystem
mailing list