[PATCH] Beautified MacroLogFeature

Allen Winter winter at kde.org
Mon Feb 23 14:12:30 CET 2009


This looks pretty good to me now.
I think we should commit it.


On Friday 20 February 2009 9:19:01 am Sebastian Trüg wrote:
> On Friday 20 February 2009 12:50:58 Thiago Macieira wrote:
> > Em Sexta-feira 20 Fevereiro 2009, às 12:01:15, David Faure escreveu:
> > > On Friday 20 February 2009, Sebastian Trüg wrote:
> > > > -----------------------------------------------------------------------
> > > >-- ---- -- The following REQUIRED dependencies could NOT be found.
> > > > -----------------------------------------------------------------------
> > > >-- ---- * KCddb  <http://multimedia.kde.org> KCddb is used to retrieve
> > > > audio CD meta data from the internet.
> > >
> > > I like this part - it takes as much space as the current stuff but
> > > the additional "-----------" makes it easier to read and the indentation
> > > of the output is better than the current macro.
> > >
> > > > -----------------------------------------------------------------------
> > > >-- ---- -- The following dependencies were found.
> > > > -----------------------------------------------------------------------
> > > >-- ---- * libDVDRead Libdvdread provides a simple foundation for reading
> > > > DVD video disks.
> > >
> > > If this could be on a single line, then it would be perfect ;-)
> >
> > One more thing: reverse the order. Please list the dependencies like this:
> >
> >  - stuff we found (abbreviated like David asked)
> >  - optional stuff we did not find
> >  - required stuff we did not find
> >
> > The required not found are the most important to be seen, so they should be
> > close to the bottom.
> 
> one more try (line breaks in the first block are only due to email 
> formatting):
> 
> 
> -----------------------------------------------------------------------------
> -- The following dependencies were found.
> -----------------------------------------------------------------------------
>    * libDVDRead - Libdvdread provides a simple foundation for reading DVD 
>      video disks.
>    * FFmpeg - Needed for the K3b FFmpeg decoder plugin which can decode 
>      virtually all audio types.
>    * Flac - Needed for the Flac audio decoder plugin.
>    * Flac++ - Needed for the Flac audio decoder plugin.
>    * Mad mp3 - Needed for the mp3 audio decoder plugin.
>    * Muse - Needed for the Musepack audio decoder plugin
>    * Sndfile - Needed for the libsndfile audio decoder plugin.
>    * Lame mp3 encoder - Needed for the lame mpf encoder encoder plugin.
>    * Ogg Vorbis - Needed for the K3b Ogg Vorbis decoder and encoder plugins.
> 
> -----------------------------------------------------------------------------
> -- The following OPTIONAL dependencies could NOT be found.
> -----------------------------------------------------------------------------
>    * Taglib (1.4.0 or higher)  <http://www.freshmeat.net/projects/taglib>
>      Read and write tags in audio files
>    * Musicbrainz (1.1 or higher)  <http://musicbrainz.org/>
>      Provide information about the CD, about the artist or about related 
>      information
> 
> -----------------------------------------------------------------------------
> -- The following REQUIRED dependencies could NOT be found.
> -----------------------------------------------------------------------------
>    * KCddb  <http://multimedia.kde.org>
>      KCddb is used to retrieve audio CD meta data from the internet.
> 
> -----------------------------------------------------------------------------
> 
> 
> _______________________________________________
> Kde-buildsystem mailing list
> Kde-buildsystem at kde.org
> https://mail.kde.org/mailman/listinfo/kde-buildsystem
> 


More information about the Kde-buildsystem mailing list