Created: kdepimlibs_include_dirs

Christophe Giboudeaux cgiboudeaux at gmail.com
Mon Feb 23 14:02:21 CET 2009


Hello,

Yesterday we created the KDEPIMLIBS_INCLUDE_DIRS definition in kdepimlibs.

This one resolves compilation errors if:
- CamelCase headers are used and
- the kdepimlibs installation prefix is not the same as the kdelibs one.

That also means that both KDEPIMLIBS_INCLUDE_DIR and KDEPIMLIBS_INCLUDE_DIRS 
actually exist.

While I'd like to remove KDEPIMLIBS_INCLUDE_DIR, this would cause headaches 
when something has to be backported and would require some extra fixing when 
it's not correctly used, eg: 
include_directories(${KDEPIMLIBS_INCLUDE_DIR}/foo)

What's the best solution ? Removing KDEPIMLIBS_INCLUDE_DIR and replace it 
everywhere or keep both and apply something like that :

Index: cmake/modules/FindKdepimLibs.cmake
===================================================================
--- cmake/modules/FindKdepimLibs.cmake  (révision 930413)
+++ cmake/modules/FindKdepimLibs.cmake  (copie de travail)
@@ -3,6 +3,7 @@
 #
 #  KDEPIMLIBS_FOUND - system has KDE PIM Libraries
 #  KDEPIMLIBS_INCLUDE_DIR - the KDE PIM Libraries include directory
+#  KDEPIMLIBS_INCLUDE_DIRS - the KDE PIM Libraries include directory with 
CamelCase headers
 #
 # It also sets variables for the following libraries:
 #   KDEPIMLIBS_AKONADI_LIBS
@@ -30,6 +31,7 @@
 #   KDEPIMLIBS_DBUS_INTERFACES_DIR
 #   KDEPIMLIBS_DBUS_SERVICES_DIR
 #   KDEPIMLIBS_INCLUDE_DIR
+#   KDEPIMLIBS_INCLUDE_DIRS
 #   KDEPIMLIBS_LIB_DIR
 #   KDEPIMLIBS_BIN_DIR
 #   KDEPIMLIBS_LIBEXEC_DIR

Christophe.



More information about the Kde-buildsystem mailing list