[PATCH] Making Soprano optional (again) in kdelibs

Maciej Mrozowski reavertm at gmail.com
Tue Dec 22 07:04:21 CET 2009


Hi

Looking at current state of requirements regarding Nepomuk libs in KDE
SC (trunk), apart from kdebase/runtime/nepomuk obviously, only
kdepim/akonadiconsole seems to have hard dependency on Nepomuk
libraries. Dependency which cannot be made optional easily as it's
been put in .ui file - browserwidget_contentview.ui (otherwise source
code is NEPOMUK_FOUND aware). Apart from that Nepomuk optionality is
provided.

Now, in kdelibs there's a little inconsistency with Nepomuk related
CMake options logic:
- Soprano is always required
- SDO is optional
- Nepomuk libs are built when both Soprano (with all needed backends
and parsers) and SDO are found

If SDO is optional then there's no need to force to Soprano required,
and if Soprano is required then there's no need to guard
add_directory(nepomuk) with Soprano_FOUND and thus whether to build
Nepomuk libs only depends on SDO presence,....but only when Soprano is
found...

Proposals (patch):
- find_library(Soprano) -> macro_optional_find_library(Soprano)
keeping Soprano backend checks (so only Soprano with all needed
backends is accepted)
- other minor changes in FindNepomuk.cmake:
* set "url" in macro_log_feature of Soprano to kdesupport (now empty)
* accidental trailing spaces removals

Other proposal - to make SDO mandatory (a'ka consistency uber alles)

Comments?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs-nepomuk.patch
Type: application/octet-stream
Size: 4538 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20091222/59a0fc4c/attachment.dll 


More information about the Kde-buildsystem mailing list