KDE/kdebase/apps/dolphin/src

[Sebastian Trueg]

The runtime patch looks good to me.
As for the SDO_MIN_VERSION: that would probably be more convenient, yes.

Maciej Mrozowski wrote:
> On Sunday 20 of December 2009 22:55:05 Maciej Mrozowski wrote:
> 
>> I'll take a look at kdepim other KDE SC modules in trunk and see whether
>>  there any spurious Soprano/SDO cmake checks.
> 
> - The only easy and safe pick is kdebase/runtime.
> 
> - Maintainers of kdebingings/python/pykde4 may want to have some means to 
> build only soprano bindings and not nepomuk or the other way around.
> 
> - KdePIM on the other hand needs SDO >= 0.2 and Soprano >= 2.3.70 so 
> FindNepomuk.cmake would need to be made aware of SDO_MIN_VERSION or similar 
> variable.
> 
> ** kdebase/runtime:
> 
> Index: CMakeLists.txt
> ===================================================================
> --- CMakeLists.txt	(revision 1064419)
> +++ CMakeLists.txt	(working copy)
> @@ -17,9 +17,7 @@
>  include(CheckIncludeFiles)
>  
>  set(SOPRANO_MIN_VERSION "2.3.70")
> -macro_optional_find_package(Soprano)
>  macro_optional_find_package(Nepomuk)
> -macro_log_feature(Soprano_FOUND "Soprano" "Soprano Libraries" "kdesupport" 
> FALSE "" "Required to build Nepomuk.")
>  macro_log_feature(Nepomuk_FOUND "Nepomuk" "Nepomuk Libraries" "kdelibs" FALSE 
> "" "Required to build Nepomuk.")
>  macro_log_feature(SOPRANO_PLUGIN_VIRTUOSOBACKEND_FOUND "Soprano Virtuoso 
> Backend" "Virtuoso storage backend for Soprano" 
> "http://soprano.sourceforge.net" FALSE "" "The Soprano Virtuoso backend is 
> required to run the Nepomuk semantic desktop system.")
>  macro_log_feature(SOPRANO_PLUGIN_RAPTORPARSER_FOUND "Soprano Raptor Parser" 
> "RDF parser plugin for Soprano" "http://soprano.sourceforge.net" FALSE "" "The 
> Soprano raptor parser plugin is required to build the Nepomuk semantic desktop 
> system.")
> @@ -61,9 +59,9 @@
>     add_subdirectory(solidautoeject)
>     add_subdirectory(solid-device-automounter)
>  endif ( UNIX )
> -if(Soprano_FOUND AND Nepomuk_FOUND AND STRIGI_STRIGIQTDBUSCLIENT_LIBRARY AND 
> SOPRANO_PLUGIN_REDLANDBACKEND_FOUND AND SOPRANO_PLUGIN_VIRTUOSOBACKEND_FOUND 
> AND SOPRANO_PLUGIN_RAPTORPARSER_FOUND)
> +if(Nepomuk_FOUND AND STRIGI_STRIGIQTDBUSCLIENT_LIBRARY AND 
> SOPRANO_PLUGIN_REDLANDBACKEND_FOUND AND SOPRANO_PLUGIN_VIRTUOSOBACKEND_FOUND 
> AND SOPRANO_PLUGIN_RAPTORPARSER_FOUND)
>    macro_optional_add_subdirectory(nepomuk)
> -endif(Soprano_FOUND AND Nepomuk_FOUND AND STRIGI_STRIGIQTDBUSCLIENT_LIBRARY 
> AND SOPRANO_PLUGIN_REDLANDBACKEND_FOUND AND 
> SOPRANO_PLUGIN_VIRTUOSOBACKEND_FOUND AND SOPRANO_PLUGIN_RAPTORPARSER_FOUND)
> +endif(Nepomuk_FOUND AND STRIGI_STRIGIQTDBUSCLIENT_LIBRARY AND 
> SOPRANO_PLUGIN_REDLANDBACKEND_FOUND AND SOPRANO_PLUGIN_VIRTUOSOBACKEND_FOUND 
> AND SOPRANO_PLUGIN_RAPTORPARSER_FOUND)
>  
>  # Plugins/components required for basic utility
>  add_subdirectory(kcontrol)
> 
> 
> ** kdepim:
> 
> 
>