Another issue with the SunStudio compiler

[Pavel Heimlich, a.k.a. hajma]

2009/12/18 Alexander Neundorf <neundorf at kde.org>:
> Hi,
>
> in kdelibs, khtml, there is another SunStudio compiler error:
> http://my.cdash.org/viewBuildError.php?buildid=41969:
>
> "/.../srcdir/khtml/xml/dom_elementimpl.h", line 135: Error: Different types
> for "?:" (DOM::DOMStringImpl*const and bool).
>
> This is line 135:
>  DOMStringImpl *val() const { return m_localName.id() ? m_data.value :
>                                                         m_data.attr->val(); }
>
>
> m_data.value is a DOMStringImpl:
>
>    union {
>        DOMStringImpl *value;
>        AttrImpl *attr;
>    } m_data;
>
>
> and AttrImpl::val() also returns a DOMStringImpl* :
>
> class AttrImpl : public NodeBaseImpl
> {
> ...
>    DOMStringImpl *val() { return m_value; }
>
>
> So, what does the compiler consider a bool here ?

Hi Alex,
the difference is in the const.
we have a patch for that, at https://bugs.kde.org/show_bug.cgi?id=191750
afaik made by adriaan.
I pinged DxSadEagle from #khtml and he promised to have a look at it
I also sent mail to kfm-devel, but apparently it did not make it
through the moderator so far.

P.

>
> Alex
>