[Patch] Fix SharedDesktopOntologies.cmake

Alexander Neundorf neundorf at kde.org
Fri Dec 18 23:14:35 CET 2009


On Wednesday 16 December 2009, Alexander Neundorf wrote:
> On Wednesday 16 December 2009, Christophe Giboudeaux wrote:
> > Hi,
> >
> > Here is a testcase and a simple fix for SharedDesktopOntologies.cmake:
> >
> > testcase:
> >
> > find_package(KDE4)
> > include(KDE4Defaults)
> > find_package(SharedDesktopOntologies 1.0) #Version 1.0 doesn't exist.
> >
> > What cmake does:
> > - opens FindSharedDesktopOntologies.cmake and start looking for
> > SharedDesktopOntologiesConfig.cmake and
> > SharedDesktopOntologiesConfigVersion.cmake
> >
> > As the 1.0 version doesn't match ${SHAREDDESKTOPONTOLOGIES_VERSION},
> > SharedDesktopOntologies_DIR:PATH=SharedDesktopOntologies_DIR-NOTFOUND
> > will be added to CMakeCache.txt and SHAREDDESKTOPONTOLOGIES_ROOT_DIR is
> > not defined.
> >
> > Here comes the problem: if not found, FindSharedDesktopOntologies tries
> > to find nie/nie.trig and considers that's enough to set
> > SHAREDDESKTOPONTOLOGIES_FOUND.
> >
> > Solution: remove the find_path part from
> > FindSharedDesktopOntologies.cmake. Patch attached.
>
> Isn't the difference between 0.1 and 0.2 that 0.2 installs the Config.cmake
> file, and 0.1 doesn't ?
>
> Then this patch would mean that we increase the required version of SDO for
> KDE from 0.1 to 0.2.

Ah, this wasn't completely true.
SDO is actually still optional in kdelibs.
So from my side, feel free to commit the patch and also specifiy version 0.2 
of SDO in kdelibs/CMakeLists.txt.

I think this should be ok and I didn't miss something.

Alex


More information about the Kde-buildsystem mailing list