KDE/kdelibs/kdecore

[Alexander Neundorf]

On Wednesday 29 April 2009, Andreas Pakulat wrote:
> On 29.04.09 11:33:05, Andrew Coles wrote:
> > SVN commit 960968 by coles:
> >
> > Likewise, need to add the library path too.
> >
> >
> >
> >  M  +1 -0      CMakeLists.txt
> >
> >
> > --- trunk/KDE/kdelibs/kdecore/CMakeLists.txt #960967:960968
> > @@ -44,6 +44,7 @@
> >  # compile lzma support if available
> >  if(LIBLZMA_FOUND)
> >     include_directories(${LIBLZMA_INCLUDEDIR})
> > +   link_directories(${LIBLZMA_LIBRARY_DIRS})
> >     set(kdecore_OPTIONAL_SRCS ${kdecore_OPTIONAL_SRCS}
> > compression/kxzfilter.cpp ) set(kdecore_OPTIONAL_LIBS
> > ${kdecore_OPTIONAL_LIBS} ${LIBLZMA_LIBRARIES})
>
> This seems wrong. LIBLZMA_LIBRARIES should already contain absolute paths
> to the LZMA libs, hence the library dirs variable is uneeded.

Andreas is right, FindLibLZMA.cmake is broken, don't hack around this in the 
CMakeLists.txt

Alex