[PATCH] bug 174806

[Thiago Macieira]

Michael Witten wrote:
>2009/4/11 Thiago Macieira <thiago at kde.org>:
>> Well, if we detect Python 2.6, then we should install to the KDE
>> prefix by default. The problem then is, of course, the surprise
>> factor: if someone upgrades, suddenly KDE starts installing to the
>> wrong path.
>>
>> I recommend, instead, that we default to the KDE prefix and, if Python
>> 2.5 or earlier is detected, we print a big warning at the end of the
>> cmake run, saying that you will not be able to run and that you should
>> set the PYTHON_SITE_PACKAGES_DIR variable instead. Even make it a
>> fatal error.
>
>I have already done ALL of this work.
>
>Did nobody read my patches?

I have done that now.

>I have been too busy to to clean up the asthaetic issues that have
>kept it out of trunk, but I honestly believe that my solution is the
>fullest and most superior suggestion (and implementation) yet.

You're right, your solution is by far the most complete one.

However, there are still problems.

If a user ran cmake with a path that doesn't exist *yet*, it'll still try 
to install to the system prefix. This is a reasonable use-case for the first 
time you try to build KDE. Not to mention the surprise factor of that 
changing in the second run. 

Also, if root is installing to /opt/kde4, the files will by default end up 
in /usr/lib/python2.6, which is outside the prefix. 

I repeat once again: unless the user tells us so in the command-line, do 
not install anything outside the prefix.

As for the cosmetic changes, it's necessary to address them, since there 
are a lot of them, which means reviewing your patches is hard. For 
example, there's a new file called ParseArgs.cmake which adds a macro that 
is not used anywhere.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20090412/b3e2e02e/attachment.sig