[PATCH] really reduced link interface

Alexander Neundorf neundorf at kde.org
Tue Sep 9 00:39:08 CEST 2008


On Tuesday 09 September 2008, Dirk Mueller wrote:
> On Friday 05 September 2008, Sune Vuorela wrote:
> > > > recently, but last I looked, kdepimlibs needs a similar depency trim
> > > > as kdelibs got.
> > >
> > > You're welcome to post patches for review :)
> >
> > I just took the easy shortcut and commented out the dependency writing in
> > kdepimlibs.
>
> Hmm, I don't see what that fixes. it will then also not export the
> link_interface_libraries. Can you be more specific in the "bloat" that
> kdepimlibs dependencies introduce?
>
> > On top of that, I just needed a bit of patching to kdeplasma-addons and
> > kdepim and a few other places.
>
> .. which you just noticed here. I think adding QTCORE_LIBRARY and similar
> to a lot of places indicates that this has been an overly greedy cut of of
> library dependencies. there is essentially no useful KDE library that does
> not depend on QtCore.

The current set_target_properties(... LINK_INTERFACE_LIBRARIES ...) has the 
issue that the "debug", "optimized" and "general" keywords are not supported.
This will be fixed in cmake 2.6.2 by adding an additional mode to 
TARGET_LINK_LIBRARIES:

TARGET_LINK_LIBRARIES(kdecore debug QtCored optimized QtCore z bz2)
TARGET_LINK_LIBRARIES(kdecore LINK_INTERFACE_LIBRARIES debug QtCored optimized 
QtCore )

This means we will have to change all the target property calls. And I think 
this also means we will only support this with the soon-to-be-released cmake 
2.6.2.

Alex


More information about the Kde-buildsystem mailing list