pkg_config quick non intrusive solution
Alexander Neundorf
neundorf at kde.org
Fri Nov 14 18:42:04 CET 2008
On Friday 14 November 2008, Patrick Spendrin wrote:
> Helio Chissini de Castro schrieb:
> > On Quinta 13 Novembro 2008, Andreas Pakulat wrote:
> >>> But (a big but), I had a look at the modules you modified, the diff
> >>> compared to the versions before is attached.
> >>>
> >>> There are _major_ problems:
> >
> > Yes, *now* i know since we discover reason
> >
> >>> FindExiv2.cmake: completely broken on Windows
>
> Where?
Here are the significant parts of FindExiv2.cmake:
if (NOT WIN32)
... some code not executed on windows
else(NOT WIN32)
#Better check
set(EXIV2_FOUND TRUE)
endif (NOT WIN32)
> >>> FindKexiv2, FindKipi: broken if pkgconfig was found but failed (the
> >>> same
>
> as well where?
KIPI_INCLUDEDIR is empty but not "NOTFOUND" if pkgconfig failed to find Kipi.
because it's not "NOTFOUND" find_path() will not search anything.
> >>> problem with find_path() as in FindStrigi yesterday), source- and
> >>> styleguide-incompatible renaming of the include dir variable
> >
> > I will fix as soon i have windows install in my machine
>
> I can do it as well, I will reread this thread this evening...
>
> >>> FindXine: completely broken, relies on pkgconfig under !Windows, under
> >>> Windows does nothing, documentation removed, source- and styleguide
> >>> incompatible renames
>
> No Xine available so far, so no idea where it should come from...
The old FindXine.cmake had more code, but now that I look closer, it also
always failed if pkgconfig failed. Will fix.
Alex
More information about the Kde-buildsystem
mailing list