pkg_config quick non intrusive solution

[Andreas Pakulat]

On 13.11.08 22:47:30, Alexander Neundorf wrote:
> On Thursday 13 November 2008, Helio Chissini de Castro wrote:
> > On Quarta 12 Novembro 2008, Alexander Neundorf wrote:
> ...
> > > I guess the FIND_LIBRARY() should have the NO_DEFAULT_PATH argument, so
> > > it only looks in the given directories. Or, probably better, use HINTS
> > > instead of PATHS, then the given dirs will be checked before the default
> > > dirs. You can also do
> > > list(APPEND QCA2_TMP_LIB ${TMP_LIB})
> > > then you don't have to check whether QCA2_TMP_LIB is empty or not.
> > >
> > > Alex
> >
> > Since this will be not the only one package affected, can we create sort of
> > a macro to do this ?
> > Will become a generic solution.
> 
> Yes. It should go into FindPkgConfig.cmake. I.e. we take the one from cmake 
> 2.6.2, modify it, and add it to kdelibs/cmake/modules/, so it will be 
> preferred over the one coming with cmake.
> 
> But (a big but), I had a look at the modules you modified, the diff compared 
> to the versions before is attached.
> 
> There are _major_ problems:
> 
> FindExiv2.cmake: completely broken on Windows
> FindKexiv2, FindKipi: broken if pkgconfig was found but failed (the same 
> problem with find_path() as in FindStrigi yesterday), source- and 
> styleguide-incompatible renaming of the include dir variable
> FindXine: completely broken, relies on pkgconfig under !Windows, under Windows 
> does nothing, documentation removed, source- and styleguide incompatible 
> renames
> FindStrigi: seems to work (but nevertheless has more modifications than I feel 
> comfortable with)

Don't want to blame anyone, but FindQCA2 was also broken, QCA2_INCLUDE_DIR
wasn't set anymore under unix using pkg-config. I've fixed that by setting
it to QCA2_INCLUDEDIR, which is set by the pkg-config stuff.

Andreas

-- 
You will feel hungry again in another hour.