kdesupport/decibel

[Matthew Woehlke]

Alexander Neundorf wrote:
> On Monday 10 November 2008, Matthew Woehlke wrote:
>> Can I commit this small adjustment also?
>>
>> Index: decibel/CMakeLists.txt
>> ===================================================================
>> --- decibel/CMakeLists.txt      (revision 882361)
>> +++ decibel/CMakeLists.txt      (working copy)
>> @@ -2,7 +2,7 @@
>>   CMAKE_MINIMUM_REQUIRED(VERSION 2.6.0)
>>   cmake_policy(SET CMP0003 NEW)
>>
>> -set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules")
>> +SET(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules"
>> ${CMAKE_MODULE_PATH})
> 
> Short answer, yes, I'd say commit.
> (but please try to use consistent lower/uppercasing for the commands, it seems 
> the other commands are lowercase, so please do it for this one too).

They are? I see one lower-case if() block, and the rest seems to be 
upper-case. I can avoid making a case change in the commit if you would 
prefer (actually I simply didn't notice that the diff resulted in a case 
change), although upper seems to be more consistent, at least within 
this particular CMakeLists.txt.

Either way is fine by me, please let me know which is preferred.

-- 
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
-- 
We are Microsoft. What you are experiencing is not a problem; it is an 
undocumented feature. -- Unknown (from fortune's bofh-excuses)