FindPlasma.cmake not ok

[Alexander Neundorf]

On Thursday 06 November 2008, Aaron J. Seigo wrote:
> On Wednesday 05 November 2008, Alexander Neundorf wrote:
> > Hi,
> >
> > FindPlasma.cmake as it is currently in kdelibs doesn't make sense.
> > Each cmake module should (or must) be self-contained, i.e. you should be
> > able to do simply
>
> ...
>
> > What would in some way work would be:
> >
> > find_package(KDE4)
>
> would it make sense to just roll the plasma check into the KDE4 check, and
> put it in that module itself? this is something winterz suggested on irc
> today, and i think i agree with him.

What do you mean ?
Find plasma in when doing find_package(KDE4) ?
Yes, this is basically what is done now (and FindPlasma.cmake is still there 
for compat. reasons).

> > This would be cleaner but not be backward compatible. But OTOH, Plasma
> > will just start staying compatible with the 4.2 release, right ?
> > So anything relying on it since 4.1 may be broken anyway ?
>
> correct. in fact, more like s/may/will/

So if that's the case, it's actually more like a different library now and 
incompatible by itself.
I think then we can "invalidate" FindPlasma.cmake for some time and remove it 
later on. (i.e. put a message(FATAL_ERROR ) in it which say what people 
should do).

Wha do you think ?

Alex