KDE/kdelibs/cmake/modules

[Modestas Vainius]

Hi,

2008 m. May 20 d., Tuesday, Allen Winter rašė:
> --- trunk/KDE/kdelibs/cmake/modules/FindX11.cmake #810371:810372
> @@ -295,6 +295,14 @@
>       SET(X11_SM_FOUND TRUE)
>    ENDIF(X11_SM_LIB AND X11_SM_INCLUDE_PATH)
>
> +  IF(NOT X11_ICE_FOUND)
> +    MESSAGE(FATAL_ERROR "\nThe X11 Inter-Client Exchange (ICE) Library
> could not be found.\nCannot continue. Please install libICE.\n") + 
> ENDIF(NOT X11_ICE_FOUND)
> +
> +  IF(NOT X11_SM_FOUND)
> +    MESSAGE(FATAL_ERROR "\nThe X11 Session Management (SM) Library could
> not be found.\nCannot contineu. Please install libSM.\n") +  ENDIF(NOT
> X11_SM_FOUND)
> +
Please revert this patch. It's not for FindX11.cmake to decide whether SM/ICE 
is needed or not. There should be checks for existence of them in 
CMakeLists.txt which actually uses these libraries instead of assuming that 
they are available implicitly (which is really what you need to fix here).

-- 
Modestas Vainius <modestas at vainius.eu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20080520/714fe672/attachment.pgp