automoc4 from kdesupport now supported for building KDE

[Andreas Pakulat]

On 04.06.08 14:25:09, David Faure wrote:
> On Wednesday 04 June 2008, Andreas Pakulat wrote:
> > > Right Alex? This is the reason for the NO_DEFAULT_PATH in FindPhonon? Or is the reason
> > > rather that you wanted CMAKE_SYSTEM_LIBRARY_PATH to have more priority than qt's [old] phonon?
> > > (but that's a tough choice, they could both be too old :)
> > > 
> > > Removing NO_DEFAULT_PATH fixes my problem (phonon is found when setting CMAKE_PREFIX_PATH correctly)
> > > OK about this patch, Alex?
> > 
> > No, thats wrong, it breaks when one has phonon in /usr/lib and also in
> > install dir, but the latter one should be used. 
> 
> This is exactly what's wrong about find_library IMHO.
> We need a way to get the following priority order:
> * user-specified prefix (CMAKE_PREFIX_PATH)
> * likely default locations (kde lib install dir etc.)
> * system fallback defaults (/usr)
> 
> > You should add a second 
> > call to find_library without NO_DEFAULT_PATH after the first one. 
> 
> That's ugly and we don't want to do that - as Brad said.

Then you need to file a bugreport for CMake and wait with the change
until KDE can require the CMake version that implements it. Sometimes
you'll have to either write your own or use a workaround for a
limitation in a given system.

> > That 
> > uses phonon from KDE paths+CMAKE_SYSTEM_LIBRARY_PATH+install dir if
> > available and else uses the one that it finds in the default paths,
> > including CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH variables.
> 
> Those last two are user-specified, surely they should have priority?

You can read about the order of things in man cmake (under find_library
section), but yes those have priority over everything else, i.e. they
are found first.

Andreas

-- 
Tomorrow, you can be anywhere.