Patch for KDE4Macros to use extra target on Windows

Matthias Kretz kretz at kde.org
Sat Jul 19 14:38:19 CEST 2008


On Saturday 19 July 2008 12:52:57 Christian Ehrlicher wrote:
> Matthias Kretz schrieb:
> > Hi,
> >
> > attached is a patch to use the new automoc macro which adds a new target
> > per default on Windows.
> >
> > Please let me know if that is what you want/need and whether I should
> > commit this.
>
> The patch doesn't look correct to me:
>
> @@ -672,7 +679,11 @@
>
>         target_link_libraries(${_target_NAME} ${QT_QTMAIN_LIBRARY}
> kdeinit_${_target_NAME})
>      else(WIN32)
> -      kde4_handle_automoc(kdeinit_${_target_NAME} _SRCS)
> +      if(WIN32)
> +         add_automoc4_target("kdeinit_${_target_NAME}_automoc" _SRCS)
> +      else(WIN32)
> +         automoc4(kdeinit_${_target_NAME} _SRCS)
> +      endif(WIN32)
>
>
> here we're already in the !WIN32 part so the above has no effect for
> WIN32 at all.

ups, yes. This was just a stupid search and replace. AFAICS kdeinit targets on 
WIN32 don't need automoc, right? So we can just remove this part of the patch.

-- 
________________________________________________________
Matthias Kretz (Germany)                            <><
http://Vir.homelinux.org/
MatthiasKretz at gmx.net, kretz at kde.org,
Matthias.Kretz at urz.uni-heidelberg.de



More information about the Kde-buildsystem mailing list