kdeartwork/kscreensaver cmake patch

Alexander Neundorf alexander.neundorf at gmx.net
Thu Dec 4 07:58:15 CET 2008

> Von: Maciej Mrozowski <reavertm at poczta.fm>
> Hello
> I'm proposing a small patch for kdeartwork (related to kscreensaver and
> its 
> xscreensaver support).
> In toplevel cmake there is macro_optional_find_library that creates cmake 
> WITH_xscreensaver variable.
> But, it's being used nowhere, and in kscreensaver (the only subproject
> that checks for it) introduces new variable WITH_Xscreensaver.

Good catch :-)

> This tiny patch fixes this little ambiguity.

Hmm, not sure that's the best way.

The variable introduced by macro_optional_find_package() can be used to disable the check for xscreensaver completely, i.e. if you want to build without xscreensaver even when it's available.
I'd say just remove the option() instead and test only for 
if(XSCREENSAVER_FOUND). If it wasn't even searched, XSCREENSAVER_FOUND will also be false.


Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger

More information about the Kde-buildsystem mailing list