Extra "CACHE" options

[Allen Winter]

On Monday 14 April 2008 13:19:18 Brad King wrote:
> Hi Folks,
>
> I just noticed that these files in kdelibs/cmake/modules:
>
>    FindAkode.cmake
I see CACHE INTERNAL  in FindAkode.cmake.  Isn't that ok?

>    FindFreetype.cmake
Fix committed.

>    FindGettext.cmake
I see CACHE FILEPATH in FindGettext.cmake.  Isn't that ok?

>    FindOpenEXR.cmake
>    FindOpenEXR.cmake
Fix committed.

>    FindPCRE.cmake
Fix committed.



>
> contain lines like
>
>    set(PCRE_LIBRARIES ${PCRE_PCRE_LIBRARY} ${PCRE_PCREPOSIX_LIBRARY}
> CACHE STRING "The libraries needed to use PCRE")
>
> These should not be cache options because they just summarize
> information given by users.  The problem created by this is that if one
> of the libraries is not found then this variable stays broken even after
> the user has specified the library location.
>
> The lines should be just
>
>    set(PCRE_LIBRARIES ${PCRE_PCRE_LIBRARY} ${PCRE_PCREPOSIX_LIBRARY})
>
> -Brad
> _______________________________________________
> Kde-buildsystem mailing list
> Kde-buildsystem at kde.org
> https://mail.kde.org/mailman/listinfo/kde-buildsystem