skipping the kdeinit magic on windows (Re:

[Ralf Habacker]

David Faure schrieb:
> On Monday 07 April 2008, Ralf Habacker wrote:
>   
>> I do not understand some things: There is a complete platform 
>> independent solution which looks nice to the package developer, which 
>> removes the if(...) issues in the CMakeLists.txt for ever
>> and it is rejected against a low level platform specific solution
>>
>> kde4_add_kdeinit_executable( kfmclient NOGUI ${kfmclient_SRCS})
>> target_link_libraries(kdeinit_kfmclient  ${KDE4_KIO_LIBS} )
>> install(TARGETS kfmclient ${INSTALL_TARGETS_DEFAULT_ARGS} )
>> if(NOT WIN32)
>>    install(TARGETS kdeinit_kfmclient ${INSTALL_TARGETS_DEFAULT_ARGS} )
>> endif(NOT WIN32)
>>
>> which is
>> - only full understandable by inspecting KDE4Macros.cmake,
>> - forces unix developer to know windows install behavior to setup the 
>> the build system correctly,
>> - needs ongoing patch effort of kde windows developer in case linux devs 
>> forgot to think about windows install behavior and
>> - needs patching of an outside tool
>>
>> only to avoid introducing two macros, which are designed to use the 
>> known call sequence(add_... _..link_libraries, __install) ????
>>
>> Sorry, please take this not personally, but I do not think that this is 
>> the right way :-P - I believe a build system should make it as much as 
>> easy for package developers and to encapsulate platform issue as much as 
>> possible into some internal macros and if it is required to introduce 
>> new macros then it should be.
>>     
>
> I agree with Ralf. Let's make it easy and correct, rather than difficult and wrong.
>
>   
... and how to proceed ? Should I add those scripts to KDE4Macros.cmake 
or should alex rework his patch or ....?

Ralf