kdelibs/kjs/CMakeLists.txt

[Matt Rogers]

On Sunday 23 September 2007 17:51:17 Andreas Pakulat wrote:
> On 23.09.07 16:58:37, Matt Rogers wrote:
> > On Sunday 23 September 2007 13:50:47 Allen Winter wrote:
> > > Howdy,
> > >
> > > I'm using cmake from cvs and it found a problem in
> > > kdelibs/kjs/CMakeLists.txt:
> > >
> > > Warning: Source file
> > > "/data/kde/trunk/KDE/kdelibs/build-gcc/kjs/kjs_automoc.cpp" is listed
> > > multiple times for target "kjs".
> > >
> > > I think this  is due to having a library named 'kjs' and a separate app
> > > named 'kjs'. The warning goes away if I change
> > >   set(kjs_SRCS kjs.cpp)
> > >   kde4_add_executable(kjs NOGUI ${kjs_SRCS})
> > >   target_link_libraries(kjs ${KJSLIBNAME})
> > >   install(TARGETS kjs DESTINATION ${BIN_INSTALL_DIR})
> > >
> > > to
> > >   set(kjs_SRCS kjs.cpp)
> > >   kde4_add_executable(kjshell NOGUI ${kjs_SRCS})
> > >   target_link_libraries(kjshell ${KJSLIBNAME})
> > >   install(TARGETS kjshell DESTINATION ${BIN_INSTALL_DIR})
> > >
> > > i.e, rename the app 'kjs' to 'kjshell'.
> > > Not sure if there is a better way to fix the warning.. I doubt
> > > we want to change the name of the kjs application.
> >
> > kde4_add_executable(kjs_bin kjs.cpp)
> > set_target_properties(kjs_bin PROPERTIES OUTPUT_NAME kjs)
> >
> > the above will work as well and keeps us from renaming the library again.
>
> Huh, why should the library need a rename? It would just stay as "kjs"
> target name. Allen is only talking about changing the app's target name
> to kjshell.
>
> Andreas

s/library/binary in my reply