kdebase dependency error

Alexander Neundorf neundorf at kde.org
Thu Nov 15 19:46:52 CET 2007


On Thursday 15 November 2007, Saro Engels wrote:
> Alexander Neundorf schrieb:
> > I think this is the hackery at the end of kdelibs/CMakeLists.txt, which
> > needs to be improved and unified.
> >
> > It's on my TODO, but I can't do it alone since I don't have windows to
> > test it.
>
> At your command, just tell me what you think should be done.

At the bottom of kdelibs/CMakeLists.txt is basically somem code, so that under 
windows you get a line
set(KDE4_INSTALL_DIR ${CMAKE_INSTALL_PREFIX})
in the KDELibsDependencies.cmake file.
Then later on this variable is prepended to alll other _INSTALL_DIR variables, 
but so that it stays a variable and will be resolved at install time, not at 
cmake time.

In the unix branch you can see a macro MAKE_INSTALL_PATH_ABSOLUTE(), which has 
branches for unix and windows. It prepends CMAKE_INSTALL_PREFIX to relative 
paths. This is then called for all _INSTALL_DIR variables.

So, this macro should be changed so that for both unix and windows it always 
prepends KDE4_INSTALL_DIR instead of CMAKE_INSTALL_PREFIX, and so that it 
prepends the variable (as it is now for windows), and not the value (as it is 
now for unix).
Then it has to be made sure that KDE4_INSTALL_DIR is set correctly in kdelibs 
both for unix and windows.
If that has been done, we can get rid of the duplicated handling of the 
install dirs for windows and unix.

Alex


More information about the Kde-buildsystem mailing list