Merging of kdelibs_export.h and kdelibs_export_win.h

Thiago Macieira thiago at kde.org
Sat Jan 20 01:53:17 CET 2007


I've noticed that CMake defines a macro called <targetname>_EXPORTS for 
each module that is being built.

Would the Win32 guys oppose if I merged the two export headers into one 
and used that macro instead?

I.e., instead of:
#ifndef KDEUI_EXPORT
# ifdef MAKE_KDEUI_LIB
#  define KDEUI_EXPORT KDE_EXPORT
# else
#  define KDEUI_EXPORT KDE_IMPORT
# endif
#endif

We'd have:
#ifndef KDEUI_EXPORT
# ifdef kdeui_EXPORTS
#  define KDEUI_EXPORT KDE_EXPORT
# else
#  define KDEUI_EXPORT KDE_IMPORT
# endif
#endif

(the change is on the second line)

This works just fine on Linux and the other Unices, in case someone is 
wondering.
-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20070120/6f17008f/attachment.pgp 


More information about the Kde-buildsystem mailing list