No NDEBUG in release mode

[Thiago Macieira]

Allen Winter wrote:
>Counter proposal:
>
>Index: FindKDE4Internal.cmake
>===================================================================
>--- FindKDE4Internal.cmake      (revision 750678)
>+++ FindKDE4Internal.cmake      (working copy)
>@@ -932,11 +932,11 @@ if (CMAKE_C_COMPILER MATCHES "icc")
>    set (KDE4_ENABLE_EXCEPTIONS -fexceptions)
>    # Select flags.
>    set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -g")
>-   set(CMAKE_CXX_FLAGS_RELEASE        "-O2")
>+   set(CMAKE_CXX_FLAGS_RELEASE        "-O2 -DNDEBUG")
>    set(CMAKE_CXX_FLAGS_DEBUG          "-O2 -g -0b0 -noalign")
>    set(CMAKE_CXX_FLAGS_DEBUGFULL      "-g -Ob0 -noalign")
>    set(CMAKE_C_FLAGS_RELWITHDEBINFO   "-O2 -g")
>-   set(CMAKE_C_FLAGS_RELEASE          "-O2")
>+   set(CMAKE_C_FLAGS_RELEASE          "-O2 -DNDEBUG")
>    set(CMAKE_C_FLAGS_DEBUG            "-O2 -g -Ob0 -noalign")
>    set(CMAKE_C_FLAGS_DEBUGFULL        "-g -Ob0 -noalign")

You probably want to add KDE_NO_DEBUG_OUTPUT as well.

Or modify kdebug.h.
-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20071220/1063b202/attachment.pgp