msvc: makekdewidgets

[Peter Kümmel]

Paulo Jorge Guedes wrote:
>> -----Original Message-----
>> From: Paulo Jorge Guedes [mailto:Paulo.Guedes at artelecom.pt]
>> Sent: segunda-feira, 15 de Maio de 2006 11:36
>> To: kde-buildsystem at kde.org
>> Subject: RE: msvc: makekdewidgets
>>
>>> -----Original Message-----
>>> From: Peter Kümmel [mailto:syntheticpp at gmx.net]
>>> Sent: segunda-feira, 15 de Maio de 2006 11:20
>>> To: kde-buildsystem at kde.org
>>> Subject: Re: msvc: makekdewidgets
>>>
>>> Paulo Jorge Guedes wrote:
>>>> I noticed your commit to FindKDEWIN32.cmake since it doesn't work
>>> anymore here :)
>>>
>>> Curious, I've tested it with msvc 8 and mingw (with mingw I've only
>>> compiled until
>>> the linking of kdecore which breaks because of a to long command line,
>> but
>>> I think
>>> this has nothing to do with my changes).
>>>
>>> Is your kdewin32 installation up to date? Here I have
>>> /lib/kdewin32dlibs
>>> /lib/libkdewin32.dll.a
>> The problem is with msvc.
>>
>>> Could you post the error message.
>> The error is that it can't find kdewin32 (on the configure step of cmake).
>> Looking at FindKDEWIN32.cmake it's not a great surprise because it tries
>> to find the libraries with a *d.
>> What happens if you have kdewin32 built with release? It doesn't find them
>> :)

Now I see, you've problems because you use -DCMAKE_BUILD_TYPE=release, am I right?

>> I think this is broken as it only allows a debug build.
> 
Yes, I also think so.

> Would this be correct?
> 
> --- FindKDEWIN32.cmake    (revision 540992) 
> +++ FindKDEWIN32.cmake    (working copy) 
> @@ -20,11 +20,11 @@
>  
>  # at first find the kdewin32 library, this has to be compiled and installed before kdelibs/
>  # search for kdewin32 in the default install directory for applications (default of (n)make install)
> -if (MSVC) 
> +if (MSVC AND CMAKE_BUILD_TYPE MATCHES Debug) 
>     set(_KDEWIN32_POSTFIX d)
> -else (MSVC) 
> +else (MSVC AND CMAKE_BUILD_TYPE MATCHES Debug) 
>     set(_KDEWIN32_POSTFIX )
> -endif (MSVC) 
> +endif (MSVC AND CMAKE_BUILD_TYPE MATCHES Debug) 
>  
>  FIND_LIBRARY(KDEWIN32_LIBRARY NAMES kdewin32${_KDEWIN32_POSTFIX}
>    PATHS

When CMAKE_BUILD_TYPE also switches the CMAKE_DEBUG_POSTFIX macro
then your patch looks good. I'll test it.

Peter