.sh wrappers

[Marcus Camen]

On Sunday 30 April 2006 13:32, David Faure wrote:
> $ cat bin/genembed.sh
> #!/bin/sh
> # created by cmake, don't edit, changes will be lost
> LD_LIBRARY_PATH=/devel/kde/build/4/kdelibs4_snapshot/lib/./:/devel/kde/
>inst/kde4/lib:/devel/kde/build/4/kdelibs4_snapshot/lib/.:/devel/kde/src/
>4/qt-copy/lib${LD_LIBRARY_PATH+:LD_LIBRARY_PATH}
> "/devel/kde/build/4/kdelibs4_snapshot/bin/genembed" "$@"
>
> Are you sure about the ${LD_LIBRARY_PATH+:LD_LIBRARY_PATH} construct?
> sh -x says:
> +
> LD_LIBRARY_PATH=/devel/kde/build/4/kdelibs4_snapshot/lib/./:/devel/kde/
>inst/kde4/lib:/devel/kde/build/4/kdelibs4_snapshot/lib/.:/devel/kde/src/
>4/qt-copy/lib:LD_LIBRARY_PATH
>
> and indeed
> $ echo ${LD_LIBRARY_PATH+:LD_LIBRARY_PATH}
>
> :LD_LIBRARY_PATH
>
> Shouldn't this be ${LD_LIBRARY_PATH+:$LD_LIBRARY_PATH} ? (with a $ in
> front of the var?) bash and zsh (and sh symlinked to bash) seem to
> agree on this.

Yep, same problem here. I suggest to apply
  -${_library_path_variable}=${_ld_library_path}\${${_library_path_variable}+:${_library_path_variable}} \"${_executable}\" \"$@\"
  +${_library_path_variable}=${_ld_library_path}\${${_library_path_variable}+:\$${_library_path_variable}} \"${_executable}\" \"$@\"

to cmake/modules/kde4_exec_via_sh.cmake

--
Marcus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20060504/16a71fe8/attachment.pgp