windows build
Peter Kümmel
syntheticpp at gmx.net
Tue Jun 27 16:19:38 CEST 2006
Paulo Jorge Guedes wrote:
>> -----Original Message-----
>> From: Peter Kümmel [mailto:syntheticpp at gmx.net]
>> Sent: terça-feira, 27 de Junho de 2006 15:08
>> To: kde-buildsystem at kde.org
>> Subject: Re: windows build
>>
>> Paulo Jorge Guedes wrote:
>>> Perhaps you should add some comment explaining why the include is
>> needed.
>> You are right, this would prevent the removing.
>>
>> I could also only include when compiled under windows.
>> But is the minimal speed up under linux worth an
>> additional ifdef?
>
> IMHO yes, not because of performance but because of correctness, as that include shouldn't be there. You can restrict the ifdef to msvc I think.
>
> Paulo
I've not tested it with mingw and it is maybe related to Dlls in general
so I've used #ifdef Q_OS_WIN.
Peter
More information about the Kde-buildsystem
mailing list