Suggested patch for FindOpenGL.cmake

David Faure faure at kde.org
Tue Jun 20 10:26:59 CEST 2006


On Monday 19 June 2006 22:12, Alexander Neundorf wrote:
> On Monday 19 June 2006 00:14, David Faure wrote:
> > Why look for X11 again, if we did so already before?
> > [e.g. due to FindQt4.cmake]
> > This should save a bit of time in reconfiguring, since FindX11 has a rather
> > large set of checks (it's even larger in kde's version of it, due to
> > additional libs), and since FindX11 doesn't have a fast path when things
> > are in the cache already (it rechecks every time).
> 
> Does this have a measurable effect ?

It has at least the effect that I dont see "Xpm not found" 4 times in kdebase :)

> Detecting the stuff (the find_xxx() calls) automatically uses the cache.

Take a look at our FindX11.cmake - there is a lot going on there, not just find_xxx.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).



More information about the Kde-buildsystem mailing list