KDE/kdelibs/kio

[Christian Ehrlicher]

Alexander Neundorf schrieb:
> On Sunday 12 February 2006 18:35, Christian Ehrlicher wrote:
> ...
>>> +if(ZLIB_FOUND)
>>> +   include_directories(${ZLIB_INCLUDE_DIR})
>>> +endif(ZLIB_FOUND)
> ...
>> why do we need to add this?
>> I mean - can't we simply say the we need ZLIB and cmake adds all things
>> automagically?
> 
> Basically:
> if (ZLIB_FOUND)
>   include_directories(${ZLIB_INCLUDE_DIR})
> endif (ZLIB_FOUND)
> ...
> if (ZLIB_FOUND)
>   target_link_libraries(kio ${ZLIB_LIBRARY})
> endif (ZLIB_FOUND)
> 
> is just that, we say "we need zlib". After all, it is a bit more typing but it 
> is simple and obvious.
It's so simple that you forgot to add it to kio... ;-)
Do you think other developers which don't know much about cmake do it right?
And imho it's getting complex when you've more than two or three libs.
Can't you simply add a new macro to handle this?

Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 250 bytes
Desc: OpenPGP digital signature
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20060212/ec112628/attachment.pgp