KDE/kdelibs/kio

[Christian Ehrlicher]

Peter Kümmel schrieb:
> Christian Ehrlicher wrote:
>> Peter Kümmel schrieb:
>>> SVN commit 508767 by kuemmel:
>>>
>>> on windows zlib.h is not in the standard include path
>>>
>>>  M  +4 -0      CMakeLists.txt  
>>>
>>>
>>> --- trunk/KDE/kdelibs/kio/CMakeLists.txt #508766:508767
>>> @@ -7,6 +7,10 @@
>>>     include_directories(${OPENSSL_INCLUDE_DIR})
>>>  endif(HAVE_SSL)
>>>  
>>> +if(ZLIB_FOUND)
>>> +   include_directories(${ZLIB_INCLUDE_DIR})
>>> +endif(ZLIB_FOUND)
>>> +
>>>  include_directories( ${KDE4_INCLUDE_DIR} ${QT_INCLUDES} ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR}
>>>  ${CMAKE_CURRENT_SOURCE_DIR}/bookmarks
>>>  ${CMAKE_SOURCE_DIR}/kwallet/client
>>>
>> why do we need to add this?
>> I mean - can't we simply say the we need ZLIB and cmake adds all things
>> automagically?
>>
>> bksys can do this ;-P
>>
>> Christian
>>
> 
> On windows we need to add it somewhere, and I've done it
> as well as it is done for the openssl or pcre (kjs) case.
But it's stupid.
Why not tell cmake that we need zlib and everytings is fine?
-> bksys:
env.uselib += 'Z PNG'
and bksys adds include path and lib...
and for optional libs maybe use something like
env.optional += 'OPENSSL'

Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 250 bytes
Desc: OpenPGP digital signature
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20060212/b56e8cc7/attachment.pgp