KDE_EXPORT in kdelibs and winposix

Ralf Habacker ralf.habacker at freenet.de
Thu Feb 9 22:26:34 CET 2006


Brad King schrieb:
> Ralf Habacker wrote:
>   
>> Brad King schrieb:
>>     
>>> I suggest that the winposix_export.h versions be renamed to 
>>> WINPOSX_EXPORT and WINPOSX_IMPORT
>>>       
>> I agree
>>     
> [snip]
>   
>>> The file win/include/mingw/sys/types.h does this:
>>>
>>> #ifdef __cplusplus
>>> #include <winposix_export.h>
>>> #else
>>> #define KDEWIN32_EXPORT
>>> #endif
>>>
>>> but it looks like it should just be
>>>
>>> #include <winposix_export.h>
>>>  
>>>       
>> The above construct was initial to prevents including qt headers for 
>> compiling c code through kdelibs_export.h. If similar support is 
>> required in the future, we can add this to winposix_export.h
>>     
>
> Thanks for making the changes, but there is one problem.  Now nothing 
> defines KDE_IMPORT.  I think it should be defined in kdemacros.h next to 
> KDE_EXPORT.
>
>   
I've added this definition in kdemacros.h.in and kdemacros.h.cmake, from 
which kdemacros.h is created.

Unfortunally I cannot check this because after running cmake with mingw 
currently no Makefile is generated.

Ralf



More information about the Kde-buildsystem mailing list