KDE_EXPORT in kdelibs and winposix

Brad King brad.king at kitware.com
Thu Feb 9 21:50:34 CET 2006


Ralf Habacker wrote:
> Brad King schrieb:
>>I suggest that the winposix_export.h versions be renamed to 
>>WINPOSX_EXPORT and WINPOSX_IMPORT
> I agree
[snip]
>>The file win/include/mingw/sys/types.h does this:
>>
>>#ifdef __cplusplus
>>#include <winposix_export.h>
>>#else
>>#define KDEWIN32_EXPORT
>>#endif
>>
>>but it looks like it should just be
>>
>>#include <winposix_export.h>
>>  
> The above construct was initial to prevents including qt headers for 
> compiling c code through kdelibs_export.h. If similar support is 
> required in the future, we can add this to winposix_export.h

Thanks for making the changes, but there is one problem.  Now nothing 
defines KDE_IMPORT.  I think it should be defined in kdemacros.h next to 
KDE_EXPORT.

-Brad


More information about the Kde-buildsystem mailing list