KDE/kdelibs/kjs

[Alexander Neundorf]

Hi ,

On Tuesday 07 February 2006 18:39, Peter Kümmel wrote:
> Alexander Neundorf wrote:
> > SVN commit 506818 by neundorf:
> >
> > -restore CMakeLists.txt
> >
> > Peter, please be a bit more careful with your commits.
>
> You are right, this one was too fast.
>
> > Where should REGEXP_INCLUDE_DIR come from ?
>
> Why did you include the list of headers to the source files ? This
> shouldn't be necessary.
>
> cmake does not create the*.lut.h files when they are not part of the
> source.
>
> > If it doesn't work, ask on kde-buildsystem at kde.org
>
> the configure process don't complain about no regex library.

Did it break the build ? It shouldn't, the ifdef HAVE_PCREPOSIX should make it 
compile also without pcre. If it breaks nevertheless, let us know.

> teher is no pthread  on windows.

Ok, fixed. pthreads isn't required explicitely, it comes automatically qith 
QT_AND_KDECORE_LIBS if required for the platform.

> > Are you sure with all your commits regarding fakes.c and kdecore ?
>
> Pretty sure, I've discussed it with Christian.
>
> > Is ifdefing the #warning pragmas the recommended way to handle this ?
>
> There are about 120 ifdefed #warnings, if've added 5-10.

Ok :-)

Bye
Alex
-- 
Work: alexander.neundorf AT jenoptik.com - http://www.jenoptik-los.de
Home: neundorf AT kde.org                - http://www.kde.org
      alex AT neundorf.net               - http://www.neundorf.net