[FEATURE REQUEST] CMake and Colors

David Faure faure at kde.org
Sun Apr 2 20:21:51 CEST 2006


On Friday 31 March 2006 21:20, Allen Winter wrote:
> On Friday 31 March 2006 13:51, Alexander Neundorf wrote:
> > On Friday 31 March 2006 20:38, Allen Winter wrote:
> > > On Friday 31 March 2006 11:58, Alexander Neundorf wrote:
> > ...
> > > > Maybe we should create a file "kdelibs/cmake/modules/KDE4Defaults.cmake"
> > > > or something like this, which contains all these settings
Excellent idea !
This way we can centralize
1) the forbidding of srcdir==builddir
2) the setting of CMAKE_INCLUDE_CURRENT_DIR to ON
3) the enabling of colors

> > > > and e.g. also the FOO_INSTALL_DIR variables.
Hmm, that's part of the kde4 paths, which apps -must- use when installing.
I thought the idea of separating those 'defaults' is that they are actually
optional; if a 3rd-party app developer already uses cmake with his own
settings, he should use FindKDE4Internal but he doesn't have to load
KDE4Defaults.cmake. Otherwise what's the point of splitting it out?

> > Yes, exactly.
> > It would go into kdelibs/cmake/modules/, and be installed to 
> > share/apps/cmake/modules/
Yep.

> Another alternative:  put KDE4Defaults.cmake into the admin directory.
> And since the admin directory is imported into each modules repository
> we get the duplication for free.
No, no - forget about admin. It will go away. We won't need it anymore.
Duplication sucks, even when automated - so why have duplication when we can 
just do "make install" in kdelibs and get the file for all other modules to use?

[ok we'll see what happens once we have to deal with kde-4.0-final's installed
cmake files being used by every 3rd party apps and then we can't change anything
in an incompatible way in those files... I just hope we'll have *really* stabilized
everything by then.]

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).



More information about the Kde-buildsystem mailing list