[Patch] fix compile kdeui with msvc

[Christian Ehrlicher]

David Faure schrieb:

> On Tuesday 01 November 2005 08:10, Ralf Habacker wrote:
> 
>>Am Montag, 31. Oktober 2005 15:47 schrieb David Faure:
>>
>>>On Monday 31 October 2005 15:27, Ralf Habacker wrote:
>>>
>>>>Append is a patch for this, does anyhave see any problem  ?
>>>
>>>CFLAGS missing?
>>>
>>>
>>>>One question is if this should be activated by default ?
>>>>
>>>>Index: generic.py
>>>>===================================================================
>>>>--- generic.py  (revision 476063)
>>>>+++ generic.py  (working copy)
>>>>@@ -285,6 +285,9 @@
>>>>                if self.libprefix != '' and
>>>>self.target[:len(self.libprefix)] == self.libprefix:
>>>>                        self.target = self.target[len(self.libprefix):]
>>>>
>>>>+               if self.type in ['shlib','kioslave','module']:
>>>>+                       self.env.AppendUnique( CCFLAGS =
>>>>['-DMAKE_'+self.target.upper()+'_LIB'] )
>>>
>>>Looks good to me. I see no reason against having this activated by default,
>>>it will be useful in all svn modules.
>>
>>also for non windows targets ? 
> 
> 
> Hmm, that's a good point, this is only useful on windows targets, so there's
> no point in cluttering the command line on other targets. 
Why should this only be usefull on windows? I thought you want to
support gcc's visibility capabilities too?

Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 250 bytes
Desc: OpenPGP digital signature
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20051101/aa1de464/signature.pgp