PyKF5 bindings generator improvements out for review.

Shaheed Haque srhaque at theiet.org
Sun Jan 29 21:09:52 UTC 2017


OK, let's start small:
https://github.com/ShaheedHaque/extra-cmake-modules/pull/2.

Please review...

On 29 January 2017 at 17:12, Stephen Kelly <steveire at gmail.com> wrote:

> Shaheed Haque wrote:
>
> > Rewrite? It think its more a case of forking making things diverge (if
> you
> > look, a lot of the changes are formatting, name changes and comments,
> > though I accept that does make for a lot of noise). I have tried VERY
> hard
> > to keep the good changes form both sides...and yes, there ARE a
> reasonable
> > number of actual changes too.
> >
> > Anyway, I was under the impression a squashed single commit was
> preferred,
> > but I can look to pull things out again. I would prefer to work the
> > reviews via github's Pull Requests, is that still OK?
>
> Yep, sounds good to me!
>
> Thanks,
>
> Steve.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-bindings/attachments/20170129/128fe0a8/attachment.html>


More information about the Kde-bindings mailing list