PyKF5 bindings generator improvements out for review.

[Shaheed Haque]

Hi Steve,

Thanks for taking a look. I'll take another look at the PR4: I think I can
split a few bits out in a more granular fashion and that should make it
easier for you.

That said, I would prefer to take the PRs in the order I posted them
because otherwise it is hard for me to track what is and is not "done",
especially as you sometimes end up changing what actually gets committed to
KDE/master; that effectively creates yet another fork for me to have to
reconcile. Ideally, I'd like us to use the PR process and let me do the
commit to KDE when we are happy: the whole point of having all the branches
and PRs split out the way they are is to make this tractable and to allow
me to incorporate your comments in a systematic manner. As we deal with
each PR, I can rebase and rewrite the subsequent PRs.

I hope that sounds OK.

Shaheed

On 4 February 2017 at 12:09, Stephen Kelly <steveire at gmail.com> wrote:

> Stephen Kelly wrote:
>
> > Simple, short and noiseless commits are easy to review, so please see if
> > you can follow suit there.
>
> In particular, I tried to review the commit "Rule database structure
> changes", but it seems to contain lots of unrelated things such as
> outputting 'discarded' instead of 'suppressed', and lots more. That is all
> noise and makes the commit hard to review.
>
> Please reduce that commit to the change in rules_SipTest.py plus whatever
> minimum change is needed to the python code to support that. The rest of
> the
> changes can either be follow-ups or can appear before the API change
> commit.
>
> Thanks,
>
> Steve.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-bindings/attachments/20170204/c5b90730/attachment.html>