Review Request 127705: Add some missing(?) link libraries

[Wolfgang Bauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127705/
-----------------------------------------------------------

(Updated Sept. 14, 2016, 10 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Bindings, Scott Kitterman and Luca Beltrame.


Changes
-------

Submitted with commit b0137f694f946c7f10ac2863a71b4cdeda15eb87 by Wolfgang Bauer to branch KDE/4.14.


Repository: pykde4


Description
-------

About 2 months ago, the build started to fail in openSUSE Factory.

We got these build errors:

[  237s] CMakeFiles/python_module_PyKDE4_dnssd.dir/sip/dnssd/sipdnssdpart2.cpp.o: In function `meth_DNSSD_ServiceBrowser_resolveHostName':
[  237s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/dnssd/sipdnssdpart2.cpp:408: undefined reference to `QHostAddress::QHostAddress(QHostAddress const&)'
[  237s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/dnssd/sipdnssdpart2.cpp:408: undefined reference to `QHostAddress::~QHostAddress()'
[  237s] collect2: error: ld returned 1 exit status
...
[  287s] CMakeFiles/python_module_PyKDE4_kio.dir/sip/kio/sipkiopart3.cpp.o: In function `meth_KFilePlacesModel_deviceForIndex':
[  287s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/kio/sipkiopart3.cpp:18560: undefined reference to `Solid::Device::Device(Solid::Device const&)'
[  287s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/kio/sipkiopart3.cpp:18560: undefined reference to `Solid::Device::~Device()'
[  287s] CMakeFiles/python_module_PyKDE4_kio.dir/sip/kio/sipkiopart4.cpp.o: In function `meth_KDeviceListModel_deviceForIndex':
[  287s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/kio/sipkiopart4.cpp:27090: undefined reference to `Solid::Device::Device(Solid::Device const&)'
[  287s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/kio/sipkiopart4.cpp:27090: undefined reference to `Solid::Device::~Device()'
[  287s] collect2: error: ld returned 1 exit status


This patch fixes them.

I'm not sure why this suddenly started to happen or whether it could be a problem in other distributions as well, but I was asked to offer the patch upstream, and it shouldn't harm anyway I think.


Diffs
-----

  CMakeLists.txt b0768cf 

Diff: https://git.reviewboard.kde.org/r/127705/diff/


Testing
-------

builds fine now on openSUSE Factory


Thanks,

Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-bindings/attachments/20160914/9ec6b1e5/attachment-0001.html>