Review Request 127705: Add some missing(?) link libraries

[Wolfgang Bauer]

> On April 21, 2016, 8:48 nachm., Luca Beltrame wrote:
> > +1 to me, it does seem harmless. I'll wait for people from other distros to comment before giving a Ship it.

Ping?

Are there any objections?

Should I commit it?


- Wolfgang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127705/#review94752
-----------------------------------------------------------


On April 21, 2016, 8:24 nachm., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127705/
> -----------------------------------------------------------
> 
> (Updated April 21, 2016, 8:24 nachm.)
> 
> 
> Review request for KDE Bindings, Scott Kitterman and Luca Beltrame.
> 
> 
> Repository: pykde4
> 
> 
> Description
> -------
> 
> About 2 months ago, the build started to fail in openSUSE Factory.
> 
> We got these build errors:
> 
> [  237s] CMakeFiles/python_module_PyKDE4_dnssd.dir/sip/dnssd/sipdnssdpart2.cpp.o: In function `meth_DNSSD_ServiceBrowser_resolveHostName':
> [  237s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/dnssd/sipdnssdpart2.cpp:408: undefined reference to `QHostAddress::QHostAddress(QHostAddress const&)'
> [  237s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/dnssd/sipdnssdpart2.cpp:408: undefined reference to `QHostAddress::~QHostAddress()'
> [  237s] collect2: error: ld returned 1 exit status
> ...
> [  287s] CMakeFiles/python_module_PyKDE4_kio.dir/sip/kio/sipkiopart3.cpp.o: In function `meth_KFilePlacesModel_deviceForIndex':
> [  287s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/kio/sipkiopart3.cpp:18560: undefined reference to `Solid::Device::Device(Solid::Device const&)'
> [  287s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/kio/sipkiopart3.cpp:18560: undefined reference to `Solid::Device::~Device()'
> [  287s] CMakeFiles/python_module_PyKDE4_kio.dir/sip/kio/sipkiopart4.cpp.o: In function `meth_KDeviceListModel_deviceForIndex':
> [  287s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/kio/sipkiopart4.cpp:27090: undefined reference to `Solid::Device::Device(Solid::Device const&)'
> [  287s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/kio/sipkiopart4.cpp:27090: undefined reference to `Solid::Device::~Device()'
> [  287s] collect2: error: ld returned 1 exit status
> 
> 
> This patch fixes them.
> 
> I'm not sure why this suddenly started to happen or whether it could be a problem in other distributions as well, but I was asked to offer the patch upstream, and it shouldn't harm anyway I think.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b0768cf 
> 
> Diff: https://git.reviewboard.kde.org/r/127705/diff/
> 
> 
> Testing
> -------
> 
> builds fine now on openSUSE Factory
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-bindings/attachments/20160914/ce810172/attachment.html>