[Kde-bindings] Review Request 116719: use GET_FILENAME_COMPONENT( ... REALPATH) to get (non-symlink) LIB_PYTHON target

Rex Dieter rdieter at gmail.com
Sun May 17 19:04:44 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116719/
-----------------------------------------------------------

(Updated May 17, 2015, 7:04 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Bindings.


Changes
-------

Submitted with commit 34bed3ceb7cd2bb43e67acce97f4cc3e8bbc1c1d by Rex Dieter to branch KDE/4.14.


Repository: pykde4


Description
-------

pykde runtime dlopen's LIB_PYTHON as returned by cmake.  This is often a symlink, but some distros (including fedora) usually package library symlinks only in -devel packaging, not runtime.  To avoid this problem, call GET_FILENAME_COMPONENT( ... REALPATH) to resolve the symlink and use that value instead.


Diffs
-----

  kpythonpluginfactory/CMakeLists.txt c24160e 

Diff: https://git.reviewboard.kde.org/r/116719/diff/


Testing
-------

fedora has been shipping with this patch since March 2014 without ill effects


Thanks,

Rex Dieter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-bindings/attachments/20150517/ec0f2693/attachment.html>


More information about the Kde-bindings mailing list