[Kde-bindings] Review Request 115082: Fix pykdeuic4 when used with newever pyqt versions

[Fabian Kosmale]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115082/
-----------------------------------------------------------

Review request for KDE Bindings, Luca Beltrame and Simon Edwards.


Bugs: 326294
    http://bugs.kde.org/show_bug.cgi?id=326294


Repository: pykde4


Description
-------

With recent versions of PyQt (at least 4.10.3), the compileUI's signature has changed from 
    def compileUi(self, input_stream, output_stream, from_imports):
to
    def compileUi(self, input_stream, output_stream, from_imports, resource_suffix):
As mentioned in the bug report, this prevents pykdeuic4 from working. The attached patch is not a final version, but more a starting point: It just passes an empty string as the last parameter. This will however break with older versions of PyQt as far as I can see. Would catching the TypeError and then calling the version with the empty string be a solution (easier to ask for forgiveness than for permission)? Or is this considered too hackish? Alternatively, one could probably choose a function based on QtCore.PYQT_VERSION_STR. Any other ideas?


Diffs
-----

  tools/pykdeuic4/pykdeuic4.py 491985a 

Diff: https://git.reviewboard.kde.org/r/115082/diff/


Testing
-------

Our (Chakra Linux's) greeter application, Kapudan, a fork of Pardus's Kaptan which requires pykdeuic4 builds; so does the dummy file attached in the linked bug.


Thanks,

Fabian Kosmale

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-bindings/attachments/20140117/db2f53e8/attachment.html>