[Kde-bindings] Review Request 116719: use GET_FILENAME_COMPONENT( ... REALPATH) to get (non-symlink) LIB_PYTHON target

Rex Dieter rdieter at gmail.com
Tue Dec 9 13:12:19 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116719/
-----------------------------------------------------------

(Updated Dec. 9, 2014, 1:12 p.m.)


Review request for KDE Bindings.


Changes
-------

update testing details


Repository: pykde4


Description (updated)
-------

pykde runtime dlopen's LIB_PYTHON as returned by cmake.  This is often a symlink, but some distros (including fedora) usually package library symlinks only in -devel packaging, not runtime.  To avoid this problem, call GET_FILENAME_COMPONENT( ... REALPATH) to resolve the symlink and use that value instead.


Diffs
-----

  kpythonpluginfactory/CMakeLists.txt c24160e 

Diff: https://git.reviewboard.kde.org/r/116719/diff/


Testing (updated)
-------

fedora has been shipping with this patch since March 2014 without ill effects


Thanks,

Rex Dieter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-bindings/attachments/20141209/0ddce284/attachment.html>


More information about the Kde-bindings mailing list