[Kde-bindings] Review Request 119679: Fix out-of-source-tree builds, install pykde_config.sip

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119679/#review64567
-----------------------------------------------------------


The out-of-tree build doesn't happen here -- I've always tested the code with out of tree builds, and never had any issues. Plus the code before my commit 0459dba0 didn't use `${CMAKE_SOURCE_DIR}` either.

As for installing the sip file: I'm fine with this solution for 4.14.0 not to block the release, but I'd like to improve this for 4.14.1. My idea with this file was to do something similar to what PyQt itself does: just add something to the `%PostInitialisationCode` section that was loaded with the .so. But I forgot `kdecoremod.sip` itself was installed and the file would be needed in these cases. For 4.14.1 I'll have to turn this into a proper .cpp file.

In short, if you're able to build Pate with your change to install `pykde_config.sip` and it then launches fine, please ship this part. But I don't think the out-of-tree fix is necessary.

(And sorry for the delay, I wasn't CC'ed in the review request and apparently wasn't subscribed to the bindings mailing list even thought I thought had done that)

- Raphael Kubo da Costa


On Aug. 14, 2014, 10:27 p.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119679/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 10:27 p.m.)
> 
> 
> Review request for KDE Bindings, Scott Kitterman, Luca Beltrame, Raphael Kubo da Costa, Andrea Scarpino, and Simon Edwards.
> 
> 
> Bugs: 338137
>     http://bugs.kde.org/show_bug.cgi?id=338137
> 
> 
> Repository: pykde4
> 
> 
> Description
> -------
> 
> Fix out-of-source-tree builds, install pykde_config.sip
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9937d04 
>   PyKDEConfigurationInformation.cmake 11bfeaa 
> 
> Diff: https://git.reviewboard.kde.org/r/119679/diff/
> 
> 
> Testing
> -------
> 
> kate's pate python plugin now buildable
> 
> 
> Thanks,
> 
> Rex Dieter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-bindings/attachments/20140814/71186d52/attachment.html>