[Kde-bindings] Review Request 119582: Update the PyQt4NoQMetaObject annotation for SIP >= 4.16.

[Luca Beltrame]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119582/#review63704
-----------------------------------------------------------

Ship it!


Looks fine to me, please commit in the stable branch then merge to master.

- Luca Beltrame


On Ago. 3, 2014, 11:26 a.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119582/
> -----------------------------------------------------------
> 
> (Updated Ago. 3, 2014, 11:26 a.m.)
> 
> 
> Review request for KDE Bindings, Luca Beltrame and Simon Edwards.
> 
> 
> Bugs: 332223
>     http://bugs.kde.org/show_bug.cgi?id=332223
> 
> 
> Repository: pykde4
> 
> 
> Description
> -------
> 
> SIP 4.16 has introduced a backwards-incompatible change by renaming the
> PyQt4NoQMetaObject annotation to PyQtNoQMetaObject.
> 
> We now have to duplicate the definition of the affected classes in our
> SIP files so that the right version with the right annotations are
> chosen based on the SIP version being used.
> 
> 
> Diffs
> -----
> 
>   sip/phonon/backendcapabilities.sip 743e8636f8507a293be2f16173a33bc206227d32 
>   sip/solid/networking.sip ef6a545b16b50358665b11cd39be32eeffddb685 
> 
> Diff: https://git.reviewboard.kde.org/r/119582/diff/
> 
> 
> Testing
> -------
> 
> Builds fine, without SIP deprecation warnings and links Phonon correctly
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-bindings/attachments/20140803/1a6e5261/attachment.html>