[Kde-bindings] Patches

Dimitar Dobrev dpldobrev at yahoo.com
Wed Jan 11 22:19:52 UTC 2012


    Steven, I actually applied most of your changes (the "lib" prefix on Windows) while working on something else, but not the whole patch. I have just pushed a proper fix for the ListWizardButtonToQListWizardButton issue - it now works without commenting anything out. Currently I have no changes in smokegen, no changes in smokeqt and only 2 changes in assemlygen - and I build everything successfully. The two changes are the QDbus issue and the "QSysInfo::windowsVersion" regex hack. The second one shouldn't be committed but it's be great if you could decrease your patch to fix the first the first one. Speaking of size, it'd be much better if you had sent separate smaller patches, one per problem. I wanted to take a look but the patch is too great and I couldn't apply all of it, for example because of the ListWizardButtonToQListWizardButton stuff. Sorry about the way all this happened but I didn't want to push such a huge patch without Arno's approval.
    I have some great news, though, you may have noticed: I implemented CLI events corresponding to Qt events (not signals). I have already pushed them and they work fine save for an issue with event filters in Qyoto, which is inherent and not caused by my changes. I have sent Arno a sample and he will take a look.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-bindings/attachments/20120111/f18ba3d5/attachment.html>


More information about the Kde-bindings mailing list