[Kde-bindings] Re: generator segfault in smoke/qtopengl

[Rex Dieter]

Arno Rehn wrote:

> On Thursday 07 October 2010 18:18:48 Rex Dieter wrote:
>> We've been seeing similar segfaults as in dashboard, gave valgrind a
>> whirl, and came up with a patch fixing the issues reported in the
>> valgrind log.
>> 
>> Please review for sanity,
>> 
>> http://rdieter.fedorapeople.org/kdebindings/valgrind.log
>> http://rdieter.fedorapeople.org/kdebindings/kdebindings-4.5.2-generator-
>> invalid-reads.patch
>> 
>> Patch attached too.

> The patch against type_compiler.cpp looks good, I'm not sure about the
> >other one, though. Is that one really necessary? 

the patched logic is sound (I think) and it makes valgrind not complain 
about invalid reads...

-- Rex