[Kde-bindings] [PATCH] Fixed building smoke plasma bindings (webkit related)
Maciej Mrozowski
reavertm at gmail.com
Fri Mar 19 02:25:23 UTC 2010
There's a problem in 4.4 branch, linking to smokeqtwebkit is inconditional
(but webkit bindings are optional).
In trunk however, http://websvn.kde.org/?view=revision&revision=1072695 has
been applied that among others fixes this issue - or at least removes some
(supposedly) unnecessary linking.
Please just in any case verify whether
http://websvn.kde.org/?view=revision&revision=1072695 can be applied to 4.4
branch (it should, it's been commited two months ago, no idea why it's not in
4.4 branch already).
Alternatively give me ack to commit attached patch to 4.4 and trunk or
backport mentioned commit.
Index: smoke/plasma/CMakeLists.txt
===================================================================
--- smoke/plasma/CMakeLists.txt (revision 1104955)
+++ smoke/plasma/CMakeLists.txt (working copy)
@@ -41,15 +41,17 @@
kde4_add_library(smokeplasma SHARED ${smokeplasma_LIB_SRCS})
-target_link_libraries(smokeplasma
+target_link_libraries(smokeplasma
${KDE4_KDEUI_LIBS}
${KDE4_PLASMA_LIBS}
smokeqtcore
smokeqtgui
- smokeqtwebkit
smokekdecore
smokekdeui
)
+IF(ENABLE_QTWEBKIT_SMOKE)
+ target_link_libraries(smokeplasma smokeqtwebkit)
+ENDIF(ENABLE_QTWEBKIT_SMOKE)
set_target_properties(smokeplasma PROPERTIES VERSION 3.0.0 SOVERSION 3 )
install(TARGETS smokeplasma DESTINATION ${LIB_INSTALL_DIR} )
--
regards
MM
More information about the Kde-bindings
mailing list