[Kde-bindings] Should QX11Info, QX11ContainerEmbed and QX11WidgetEmbed by added to qtgui smoke lib?

[Melton, Ryan]

The Windows QT Distribution does not include those files, please make sure that are wrapped with some sort of #ifdef so that things will still compile on Windows...

-----Original Message-----
From: Richard Dale [mailto:rdale at foton.es] 
Sent: Monday, November 30, 2009 8:00 AM
To: kde-bindings at kde.org
Cc: saloution at googlemail.com
Subject: [Kde-bindings] Should QX11Info,QX11ContainerEmbed and QX11WidgetEmbed by added to qtgui smoke lib?

Robert Riemann asked me about including the three X11 specific Qt classes in 
the qtgui smokelib. I said we could either do a mini-smoke lib with just them 
in, or we could added them. I tried adding the includes for them, and the 
classes to the classes list, and the smoke lib builds fine.

Index: smokeconfig.xml                                                                                                      
===================================================================                                                         
--- smokeconfig.xml     (revision 1055285)                                                                                  
+++ smokeconfig.xml     (working copy)                                                                                      
@@ -29,6 +29,7 @@                                                                                                           
         <!-- windows internal helper functions -->                                                                         
         <signature>.*qFrom.*Endian_helper.*</signature>                                                                    
         <signature>.*QPixmapData.*</signature>                                                                             
+        <signature>.*qt_x11_getX11InfoForWindow.*</signature>                                                              
    </exclude>                                                                                                              
     <functions>                                                                                                            
         <!-- include functions starting with 'q' -->                                                                       

Index: qtgui_includes.h
===================================================================
--- qtgui_includes.h    (revision 1055285)
+++ qtgui_includes.h    (working copy)
@@ -1,2 +1,4 @@
 #include <QtCore/QtCore>
 #include <QtGui/QtGui>
+#include <QtGui/qx11info_x11.h>
+#include <QtGui/qx11embed_x11.h>

So should I add them? Or will it cause problems on platforms with the classes 
don't exist?

-- Richard
_______________________________________________
Kde-bindings mailing list
Kde-bindings at kde.org
https://mail.kde.org/mailman/listinfo/kde-bindings



This message and any enclosures are intended only for the addressee.  Please  
notify the sender by email if you are not the intended recipient.  If you are  
not the intended recipient, you may not use, copy, disclose, or distribute this  
message or its contents or enclosures to any other person and any such actions  
may be unlawful.  Ball reserves the right to monitor and review all messages  
and enclosures sent to or from this email address.